[
https://issues.apache.org/jira/browse/MAPREDUCE-927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amareshwari Sriramadasu updated MAPREDUCE-927:
----------------------------------------------
Attachment: patch-927-3.txt
Patch merged with trunk and incorporates most of the comments.
bq. addJobLogsForDeletion() should not itself take jobcompletion time, it
should instead be taken from clock.
I think it makes sense to pass this as a parameter. In future, we should get
job completion time from JobTracker.
bq. TestTaskTrackerLocalization.verifyUserLogsCleanup(): shouldn't you be
setting the clock and use an inline cleaner?
bq. Should use clock and inline clear similar to the last comment above
Tests already use inline cleanup.
> Cleanup of task-logs should happen in TaskTracker instead of the Child
> ----------------------------------------------------------------------
>
> Key: MAPREDUCE-927
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-927
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: security, tasktracker
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Amareshwari Sriramadasu
> Priority: Blocker
> Fix For: 0.22.0
>
> Attachments: patch-927-1.txt, patch-927-2.txt, patch-927-3.txt,
> patch-927.txt
>
>
> Task logs' cleanup is being done in Child now. This is undesirable atleast
> for two reasons: 1) failures while cleaning up will affect the user's tasks,
> and 2) the task's wall time will get affected due to operations that TT
> actually should own.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
