[
https://issues.apache.org/jira/browse/MAPREDUCE-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842996#action_12842996
]
Hemanth Yamijala commented on MAPREDUCE-1415:
---------------------------------------------
Looks good overall. Very minor suggestions:
- In PipeMapRed.configure, can we use File.setExecutable(true) instead of
FileUtil.chmod ? With FileUtil.chmod, I suppose an exception will be thrown if
there's an invalid path passed. To maintain that semantics, we probably need to
check the return value of File.setExecutable and throw a wrapped IOException
when that happens.
- In testStreaming, we can use TEST_DIR.toAbsolutePath() as the value of
stream.tmpdir.
- Very minor - in testStreamingWithDistCache, I suggest we use a variable to
store the file name of the input script, test.sh.
> With streaming jobs and LinuxTaskController, the localized streaming binary
> has 571 permissions instead of 570
> --------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1415
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1415
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/streaming, security
> Reporter: Vinod K V
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.22.0
>
> Attachments: patch-1415-1.txt, patch-1415.txt
>
>
> After MAPREDUCE-856, all localized files are expected to have **0 permissions
> for the sake of security.
> This was found by Karam while testing LinuxTaskController functionality after
> MAPREDUCE-856.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
