[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846857#action_12846857
 ] 

Amareshwari Sriramadasu commented on MAPREDUCE-1418:
----------------------------------------------------

Had a quick look at the patch. prepare_task_logs method should return 
PREPARE_TASK_LOGS_FAILED if there is any failure, currently it returns 
PREPARE_JOB_LOGS_FAILED. prepare_job_logs method should return 
PREPARE_JOB_LOGS_FAILED if there is any failure.

> LinuxTaskController binary misses validation of arguments passed for relative 
> components in some cases.
> -------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1418
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1418
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: security, tasktracker
>            Reporter: Vinod K V
>            Assignee: Hemanth Yamijala
>         Attachments: MAPREDUCE-1418.patch
>
>
> The function {{int check_path_for_relative_components(char * path)}} should 
> be used to validate the absence of relative components before any operation 
> is done on those paths. This is missed in all the {{initialize*()}} 
> functions, as Hemanth pointed out offline.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to