[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848439#action_12848439
 ] 

Konstantin Boudnik commented on MAPREDUCE-1616:
-----------------------------------------------

- Looks like UserNamePermission modification is irrelevant
- There's a number of occasions where new FsPermission objects are created from 
something like "777" or "755". I think having something like this
{noformat}
final FsPermission _777 = new FsPermission("777");
...
                   Assert.assertTrue(fsPerm.equals(_777));
{noformat}
would reduce a number of created objects yet will make code easier to read.
- add some meaningful messages to the assert statements. Having 'null' message 
in an assertion doesn't help to diagnose a problem


> Automate system test case for checking the file permissions in 
> mapred.local.dir
> -------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1616
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1616
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>    Affects Versions: 0.20.3
>         Environment: Herriot framework is required for running the test. 
>            Reporter: Balaji Rajagopalan
>         Attachments: patch_3392207_7.txt
>
>   Original Estimate: 0.27h
>  Remaining Estimate: 0.27h
>
> The file under mapred.local.dir permission must be recursively tested when 
> the task is running, for this use the controllable task, so the temporary 
> file permission can be checked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to