[
https://issues.apache.org/jira/browse/MAPREDUCE-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849436#action_12849436
]
Hong Tang commented on MAPREDUCE-1523:
--------------------------------------
Patch looks good. One minor nit:
For the following:
{noformat}
for (int j = 0; j < statuses.length; ++j) {
String name = statuses[j].getPath().getName();
- if (!(name.length() >= 4 && ".crc".equals(name.substring(name
- .length() - 4)))) {
+ if (!(name.endsWith(".crc") || name.startsWith("."))) {
dirNames.add(name);
}
}
{noformat}
can we also skip directories in the loop? Namely changing the above code block
to something like the following:
{noformat}
for (FileStatus s : statuses) {
if (s.isDir()) continue;
String name = s.getPath().getName();
if (!(name.endsWith(".crc") || name.startsWith("."))) {
dirNames.add(name);
}
}
{noformat}
> Sometimes rumen trace generator fails to extract the job finish time.
> ---------------------------------------------------------------------
>
> Key: MAPREDUCE-1523
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1523
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Hong Tang
> Assignee: Dick King
> Attachments: mapreduce-1523--2010-02-24.patch,
> mapreduce-1523--2010-02-25.patch, mapreduce-1523--2010-03-24.patch
>
>
> We saw sometimes (not very often) that rumen may fail to extract the job
> finish time from Hadoop 0.20 history log.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
