[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856290#action_12856290
 ] 

Balaji Rajagopalan commented on MAPREDUCE-1677:
-----------------------------------------------

The same comment try to avoid two inner for loops, using data structure such as 
vector instead of array, will remove one inner for loop.
I see lot of commonality between this test case and other two distributed cache 
test case, the code duplication can be avoid if the
common functionality is pushed into a function and reused. 

localDirOnly = localDir + Path.SEPARATOR + TaskTracker.SUBDIR + 
+              Path.SEPARATOR +  userName;

The above code can be replaced by calling a method in the tasktracker, it 
already provides such nice utility methods. 

> Test scenario for a distributed cache file behaviour  when the file is private
> ------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1677
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1677
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Iyappan Srinivasan
>            Assignee: Iyappan Srinivasan
>         Attachments: 
> TEST-org.apache.hadoop.mapred.TestDistributedCachePrivateFile.txt, 
> TestDistributedCachePrivateFile.patch, TestDistributedCachePrivateFile.patch
>
>
>  Verify the Distributed Cache functionality.
>  This test scenario is for a distributed cache file behaviour  when the file 
> is private. Once a job uses a distributed 
> cache file with private permissions that file is stored in the  
> mapred.local.dir, under the directory which has the same name 
>  as job submitter's username. The directory has 700 permission  and the file 
> under it, should have 777 permissions. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to