[
https://issues.apache.org/jira/browse/MAPREDUCE-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856486#action_12856486
]
Konstantin Boudnik commented on MAPREDUCE-1671:
-----------------------------------------------
Looking better. Now the comments for the code:
- is this an _official_ name to compare to jobIDs by {{toString()}} them and
then run {{equals()}} on the result strings? Can't jobIDs be matches directly
i.e. {{jobID1.equals(jobID2)}} or similar?
- If not then this seems like an excessive call to {{getID().toString()}}
{noformat}
+ //Temporarily store the jobid to use it later for comparison.
+ String jobidStore = rJob.getID().toString();
+ LOG.info("job id is :" + rJob.getID().toString());
{noformat}
- names {{client}} and {{wovenClient}} are in-descriptive. Perhaps
{{jobClient}} and {{remoteJTClient}} will be a better choices? {{wovenClient}}
implies a prerequisite knowledge about underlying AspectJ technology.
> Test scenario for "Killing Task Attempt id till job fails"
> ----------------------------------------------------------
>
> Key: MAPREDUCE-1671
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1671
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: test
> Reporter: Iyappan Srinivasan
> Assignee: Iyappan Srinivasan
> Attachments: TEST-org.apache.hadoop.mapred.TestTaskKilling.txt,
> TestTaskKilling.patch, TestTaskKilling.patch, TestTaskKilling.patch
>
>
> 1) In a job, kill the task attemptid of one task. Whenever that task tries
> to run again with another task atempt id for mapred.map.max.attempts times,
> kill that task attempt id. After the mapred.map.max.attempts times, the whole
> job should get killed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
