[
https://issues.apache.org/jira/browse/MAPREDUCE-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858784#action_12858784
]
Vinay Kumar Thota commented on MAPREDUCE-1710:
----------------------------------------------
3) resetClusterWithNewConfigMapred seems a better name than resetCluster,
becuse users can understand the intent of this feature just by reading the name
rather than seeing the javadocs. The same goes with resetCluster. It can be
resetClusterWithOldConfig.
[Vinay] : Even I agreed your point and also I thought of defining same kind of
method names while developing,however I felt that restartCluster and
resetCluster would be fine and there won't be a lengthy method name. Any how
user can understand the behavior of method by reading the java docs. So I felt
that there is not importance of putting lengthy method name.
5) if (!tttInfo.isTaskCleanupTask()) - Even setup task could be checked to
avoid it and made fully sure its only mapper.
[Vinay]: I didn't see any method for specific to setup cleanup in ttInfo. the
method isTaskCleanupTask might be checking for both.
Apart from above two comments, I have addressed all other comments and attached
the latest patch.
> Process tree clean up of exceeding memory limit tasks.
> ------------------------------------------------------
>
> Key: MAPREDUCE-1710
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1710
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: test
> Reporter: Vinay Kumar Thota
> Assignee: Vinay Kumar Thota
> Attachments: memorylimittask_1710.patch
>
>
> 1. Submit a job which would spawn child processes and each of the child
> processes exceeds the memory limits. Let the job complete . Check if all the
> child processes are killed, the overall job should fail.
> 2. Submit a job which would spawn child processes and each of the child
> processes exceeds the memory limits. Kill/fail the job while in progress.
> Check if all the child processes are killed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
