[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861244#action_12861244
 ] 

Hong Tang commented on MAPREDUCE-1711:
--------------------------------------

There still seem to be some bugs in the code.
- MockJob.getQueueName() should not rely on seq to get the queue name. Consider 
the case when we call oneMockJob.getQueueName() after a few more mock jobs are 
created after oneMockJob.
- The mapping from job name to queue name in DebugJobProducer should not be 
static.
- In the following code, it is a bad idea to hardwire the knowledge how gridmix 
construct names. Also, the sequencing of gridmix jobs could be different from 
mock jobs. Cannot you just do job.getConfiguration().get(GridmixJob.ORIGNAME)?
{noformat}
+        } else {
+          assertEquals(
+            " Improper queue for  " + job.getJobName() + " ",
+            job.getConfiguration().get("mapred.job.queue.name"),
+            DebugJobProducer.getQueueName(
+              job.getJobName().replace(
+                "GRIDMIX", "MOCKJOB")));
+        }
{noformat}


> Gridmix should provide an option to submit jobs to the same queues as 
> specified in the trace.
> ---------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1711
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1711
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/gridmix
>            Reporter: Hong Tang
>         Attachments: MR-1711-yhadoop-20-1xx-2.patch, 
> MR-1711-yhadoop-20-1xx-3.patch, MR-1711-yhadoop-20-1xx-4.patch, 
> MR-1711-yhadoop-20-1xx.patch, mr-1711-yhadoop-20.1xx-20100416.patch
>
>
> Gridmix should provide an option to submit jobs to the same queues as 
> specified in the trace.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to