[ https://issues.apache.org/jira/browse/MAPREDUCE-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861653#action_12861653 ]
Hadoop QA commented on MAPREDUCE-1568: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443005/MAPREDUCE-1568-v3.txt against trunk revision 938576. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/149/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/149/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/149/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/149/console This message is automatically generated. > TrackerDistributedCacheManager should clean up cache in a background thread > --------------------------------------------------------------------------- > > Key: MAPREDUCE-1568 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1568 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Affects Versions: 0.22.0 > Reporter: Scott Chen > Assignee: Scott Chen > Fix For: 0.22.0 > > Attachments: MAPREDUCE-1568-v2.1.txt, MAPREDUCE-1568-v2.txt, > MAPREDUCE-1568-v3.txt, MAPREDUCE-1568.txt > > > Right now the TrackerDistributedCacheManager do the clean up with the > following code path: > {code} > TaskRunner.run() -> > TrackerDistributedCacheManager.setup() -> > TrackerDistributedCacheManager.getLocalCache() -> > TrackerDistributedCacheManager.deleteCache() > {code} > The deletion of the cache files can take a long time and it should not be > done by a task. We suggest that there should be a separate thread checking > and clean up the cache files. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.