[
https://issues.apache.org/jira/browse/MAPREDUCE-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863286#action_12863286
]
Vinay Kumar Thota commented on MAPREDUCE-1730:
----------------------------------------------
Code looks good. However, there are two more comments.
{noformat}
static final Log LOG = LogFactory.
getLog(TestRetiredJobs.class);
Indentation issue in the above statement. the continuation line should have
four spaces before starting.
{noformat}
{noformat}
int count = 0;
while (jInfo != null && !jInfo.getStatus().isJobComplete()) {
Thread.sleep(10000);
jInfo = remoteJTClient.getJobInfo(rJob.getID());
//If the count goes more than 100 seconds, then fail; This is to
//avoid infinite loop
if (count > 10) {
Assert.fail("Since the job has not started even after" +
"100 seconds, failing at this point");
}
}
* Don't see the count increment in the above block.
* Indentation issue in the Assert statement.
{noformat}
> Automate test scenario for successful/killed jobs' memory is properly removed
> from jobtracker after these jobs retire.
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1730
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1730
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Iyappan Srinivasan
> Fix For: 0.22.0
>
> Attachments: TestJobRetired.patch, TestRetiredJobs.patch
>
>
> Automate using herriot framework, test scenario for successful/killed jobs'
> memory is properly removed from jobtracker after these jobs retire.
> This should test when successful and failed jobs are retired, their
> jobInProgress object are removed properly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
