[
https://issues.apache.org/jira/browse/MAPREDUCE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinay Kumar Thota updated MAPREDUCE-1713:
-----------------------------------------
Attachment: 1713-ydist-security.patch
Looking almost good. However, AbstractDaemonCluster.java should import
MRCluster class. It's a wrong dependency.
[Vinay] : Removed the unused MRCluster import.
Is it possible that chkDaemonStart.get(ind) returns null and then calling
join() on it will produce NPE?
[Vinay]: I don't think so it may return the null value because we are creating
the thread instance everytime for each daemon and adding then into the list.
Even run method is handling the exception, so in my opinion there is no
possibility of getting NPE.
why clusterManager is used in some places and isn't in others (on more than one
occasion)?
[Vinay]: start() and stop() methods implemented in AbstractDamenonCluster class
itself and those two methods are internally calling the clusterManager. So, I
am using those two methods directly instead of calling them by using
clusterManager.However, the other two methods are available in
ClusterProcessManager class, so I am calling them by using clusterManager
instance.
warning message needs to be added if wait was unsuccessful.
[Vinay] : For waiting using the utils method.So,that method might be handling
the warning message for unsuccessful waits.
shorter form of for loop can be used perhaps for waitForClusterToStop() and
waitForClusterToStart(). Instead of
[Vinay] : Addressed the code as per your comment.
incorrect JavaDocs
[Vinay] : Addressed all the incorrect java docs in the code.
> Utilities for system tests specific.
> ------------------------------------
>
> Key: MAPREDUCE-1713
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1713
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: test
> Reporter: Vinay Kumar Thota
> Assignee: Vinay Kumar Thota
> Attachments: 1713-ydist-security.patch, 1713-ydist-security.patch,
> 1713-ydist-security.patch, systemtestutils_MR1713.patch,
> utilsforsystemtest_1713.patch
>
>
> 1. A method for restarting the daemon with new configuration.
> public static void restartCluster(Hashtable<String,Long> props, String
> confFile) throws Exception;
> 2. A method for resetting the daemon with default configuration.
> public void resetCluster() throws Exception;
> 3. A method for waiting until daemon to stop.
> public void waitForClusterToStop() throws Exception;
> 4. A method for waiting until daemon to start.
> public void waitForClusterToStart() throws Exception;
> 5. A method for checking the job whether it has started or not.
> public boolean isJobStarted(JobID id) throws IOException;
> 6. A method for checking the task whether it has started or not.
> public boolean isTaskStarted(TaskInfo taskInfo) throws IOException;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
