[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinay Kumar Thota updated MAPREDUCE-1753:
-----------------------------------------

    Attachment: 1753-ydist-security.patch

- once a DaemonProcess in question is suspended (i.e. its VM is effectively 
suspended) will you be able to resume it via a method invocation in a class 
running on that VM? I haven't verified it but something tells me that it won't 
work.

Actually I am not suspending the daemonprocess. I am just suspending the task 
attempt process id that is running on separate JVM. So, in this case we can 
suspend and resume the task attempt process without any issues. However, I have 
written those methods in more generic manner and keeping them in DameonCluster 
for utilizing other purposes.

- instead of returning 0 and 1 (??) return boolean
I used the integer value because of exitcode format.Usually if you run a 
command and if it is not successful then return some exitcode right.I followed 
the same case here.

- property name test.system.task.resume.cmd isn't consistent with the rest of 
properties from system-test.xml. Also, the default has to be added to 
system-test.xml and documented properly.
- same for @return not @ return
- as usual, missing descriptions of @throws

Done

Uploaded the latest patch by addressing the given comments.


> Implement a functionality for suspend and resume the process.
> -------------------------------------------------------------
>
>                 Key: MAPREDUCE-1753
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1753
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>          Components: test
>            Reporter: Vinay Kumar Thota
>            Assignee: Vinay Kumar Thota
>         Attachments: 1753-ydist-security.patch, 1753-ydist-security.patch, 
> daemonprotocolaspect.patch
>
>
> Adding  two methods in DaemonProtocolAspect.aj for suspend and resume the 
> process.
> public int DaemonProtocol.resumeProcess(String pid) throws IOException;
> public int DaemonProtocol.suspendProcess(String pid) throws IOException;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to