[
https://issues.apache.org/jira/browse/MAPREDUCE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868370#action_12868370
]
Konstantin Boudnik commented on MAPREDUCE-1793:
-----------------------------------------------
The above suggestion seems to be faulty because it recommends to add the
exclusions to the {{filePattern}} instead of {{pattern}}. Essentially, grep
will be looking for {{pattern}} inside of the files named after exceptions
intended to be excluded.
> Exception exculsion functionality is not working correctly.
> -----------------------------------------------------------
>
> Key: MAPREDUCE-1793
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1793
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Reporter: Vinay Kumar Thota
> Assignee: Balaji Rajagopalan
>
> Exception exclusion functionality is not working correctly because of that
> tests are failing by not matching the error count.
> I debugged the issue and found that the problem with shell command which is
> generating in the getNumberOfMatchesInLogFile function.
> Currently building the shell command in the following way.
> if(list != null){
> for(int i =0; i < list.length; ++i)
> {
> filePattern.append(" | grep -v " + list[i] );
> }
> }
> String[] cmd =
> new String[] {
> "bash",
> "-c",
> "grep -c "
> + pattern + " " + filePattern
> + " | awk -F: '{s+=$2} END {print s}'" };
> However, The above commnad won't work correctly because you are counting the
> exceptions in the file before excluding the known exceptions.
> In this case it gives the mismatch error counts everytime.The shell command
> should be in the following way to work correctly.
> if (list != null) {
> int index = 0;
> for (String excludeExp : list) {
> filePattern.append((++index < list.length)? "| grep -v " :
> "| grep -vc " + list[i] );
> }
> }
> String[] cmd =
> new String[] {
> "bash",
> "-c",
> "grep "
> + pattern + " " + filePattern
> + " | awk -F: '{s+=$2} END {print s}'" };
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
