[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874132#action_12874132
 ] 

Scott Chen commented on MAPREDUCE-1829:
---------------------------------------

There is no unit test change because the code path is already tested by the 
original unit tests.

> JobInProgress.findSpeculativeTask should use min() to find the candidate 
> instead of sort()
> ------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1829
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1829
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: jobtracker
>    Affects Versions: 0.22.0
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-1829.txt
>
>
> findSpeculativeTask needs only one candidate to speculate so it does not need 
> to sort the whole list. It may looks OK but someone can still submit big jobs 
> with small slow task thresholds. In this case, this sorting becomes expensive.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to