[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874472#action_12874472
 ] 

Balaji Rajagopalan commented on MAPREDUCE-1827:
-----------------------------------------------

1. Exception exclusion is only meant to used when there is pushConfig/restart 
of cluster is required, not in all the test cases. 
2. Function testStreamingJobStatusForFailedTask and 
testStatusOfKilledTaskWithSignalSleepTime the only difference is 

+    String runtimeArgs [] = {
+        "-D", "mapred.job.name=Numbers Sum",
+        "-D", "mapred.map.tasks=1",
+        "-D", "mapred.reduce.tasks=1",
+        "-D", "mapred.tasktracker.tasks.sleeptime-before-sigkill=3000" };

+    networkJob.killTask(taskAttID, false);

and most the other code is common, so we can very well create a common 
function, and use it. 

3. Please add comments in the streamMapper.sh explaining what it really does. 

Other than that I found the code good. 

> Task Killing/Failing tests for a streaming job.
> -----------------------------------------------
>
>                 Key: MAPREDUCE-1827
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1827
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>          Components: test
>            Reporter: Vinay Kumar Thota
>            Assignee: Vinay Kumar Thota
>         Attachments: 1827-ydist-security.patch
>
>
> 1. Set the sleep time for the tasks is 3 seconds and kill the task of 
> streaming job using SIGKILL. After that  verify whether task is killed after 
> 3 seconds or not and also verify whether job is succeeded or not.
> 2. Set the maximum attempts for the maps and reducers are one. make the task 
> to fail and verify whether task  is failed or not.Also verify whether the job 
> is failed or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to