[
https://issues.apache.org/jira/browse/MAPREDUCE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881397#action_12881397
]
Zheng Shao commented on MAPREDUCE-1887:
---------------------------------------
Code looks good.
Can we change
{code}
+ * @param nonCanonicalVols The roots of the file system volumes, which may
not
+ * be canonical paths.
{code}
to
{code}
+ * @param nonCanonicalVols The roots of the file system volumes, which can
be
+ * absolute paths from root or relative path from cwd.
{code}
?
I think the second one is easier to understand.
> MRAsyncDiskService does not properly absolutize volume root paths
> -----------------------------------------------------------------
>
> Key: MAPREDUCE-1887
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1887
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1887.2.patch, MAPREDUCE-1887.patch
>
>
> In MRAsyncDiskService, volume names are sometimes specified as relative
> paths, which are not converted to absolute paths. This can cause errors of
> the form "cannot delete </full/path/to/foo> since it is outside of
> <relative/volume/root>" even though the actual path is inside the root.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
