[ https://issues.apache.org/jira/browse/MAPREDUCE-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882041#action_12882041 ]
Amareshwari Sriramadasu commented on MAPREDUCE-1850: ---------------------------------------------------- Some comments on the patch: 1. Can you add the new configuration names to MRJobConfig and use String constants every where? 2. I don't think links given in javadoc in JobConf methods will work, as there are no such classes. I don't know why javadoc is not complaining. Can you change them to plain text instead of links? 3. Minor : Can you remove the comment saying "// auto generated stub" from JobInProgress getters? > Include job submit host information (name and ip) in jobconf and jobdetails > display > ----------------------------------------------------------------------------------- > > Key: MAPREDUCE-1850 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1850 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Affects Versions: 0.22.0 > Reporter: Krishna Ramachandran > Assignee: Krishna Ramachandran > Attachments: mapred-1850-1.patch, mapred-1850-2.patch, > mapred-1850-3.patch, mapred-1850.patch, mapred-1850.patch > > > Enhancement to identify the source (submit host and ip) of a job request. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.