[
https://issues.apache.org/jira/browse/MAPREDUCE-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883703#action_12883703
]
Konstantin Boudnik commented on MAPREDUCE-1854:
-----------------------------------------------
- Consider lowering log levels in {{JobTrackerAspect.aj}}. I think there's no
need to print clearly debug messages with *INFO* level.
- {{+ * @return int}} isn't very informative.
- this is very C-like programming style:
{noformat}
+ /**
+ * This gets the value of all task trackers windows in the tasktracker page.
+ *
+ * @param none,
+ * @return int[] of all the tasks that ran, in the sequence given below
+ * "since_start", "total_tasks"
+ * "since_start","succeeded_tasks"
+ * "last_hour", "total_tasks"
+ * "last_hour", "succeeded_tasks"
+ * "last_day", "total_tasks"
+ * "last_day", "succeeded_tasks"
+ */
{noformat}
why don't you use an object container instead? It will make code like this
{noformat}
+ int totalTasksSinceStartBeforeJob = ttAllInfo[0];
+ int succeededTasksSinceStartBeforeJob = ttAllInfo[1];
+ int totalTasksLastHourBeforeJob = ttAllInfo[2];
+ int succeededTasksLastHourBeforeJob = ttAllInfo[3];
{noformat}
much clearer and readable.
- bad choice of class name {{TestTaskTrackerInfoFirst}} as well as
{{TestTaskTrackerInfoSecond}}
- some of the tests are commented out {{//@Test}}. Please consider to take them
away all together if they aren't going to be used. You'd better add them later
in a separate JIRA.
- in the second test class waiting and log levels in {{waitForTTStop()}} and
{{waitForTTStart()}} seem to be inconsistent.
> [herriot] Automate health script system test
> --------------------------------------------
>
> Key: MAPREDUCE-1854
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1854
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Components: test
> Environment: Herriot framework
> Reporter: Balaji Rajagopalan
> Assignee: Balaji Rajagopalan
> Attachments: health_script_5.txt, health_script_7.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> 1. There are three scenarios, first is induce a error from health script,
> verify that task tracker is blacklisted.
> 2. Make the health script timeout and verify the task tracker is blacklisted.
> 3. Make an error in the health script path and make sure the task tracker
> stays healthy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
