[ https://issues.apache.org/jira/browse/MAPREDUCE-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883805#action_12883805 ]
Ravi Gummadi commented on MAPREDUCE-1864: ----------------------------------------- Patch looks good. +1 > PipeMapRed.java has uninitialized members log_ and LOGNAME > ----------------------------------------------------------- > > Key: MAPREDUCE-1864 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1864 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: contrib/streaming > Reporter: Amareshwari Sriramadasu > Assignee: Amareshwari Sriramadasu > Fix For: 0.22.0 > > Attachments: patch-1864.txt > > > PipeMapRed.java has members log_ and LOGNAME, which are never initialized and > they are used in code for logging in several places. > They should be removed and PipeMapRed should use commons LogFactory and Log > for logging. This would improve code maintainability. > Also, as per [comment | > https://issues.apache.org/jira/browse/MAPREDUCE-1851?focusedCommentId=12878530&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12878530], > stream.joblog_ configuration property can be removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.