[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885923#action_12885923
 ] 

Hadoop QA commented on MAPREDUCE-1820:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12448863/M1820-5.patch
  against trunk revision 960808.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/290/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/290/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/290/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/290/console

This message is automatically generated.

> InputSampler does not create a deep copy of the key object when creating a 
> sample, which causes problems with some formats like SequenceFile<Text,Text>
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1820
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1820
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Alex Kozlov
>            Assignee: Alex Kozlov
>         Attachments: M1820-4.patch, M1820-5.patch, MAPREDUCE-1820-2.patch, 
> MAPREDUCE-1820-3.patch, MAPREDUCE-1820.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I tried to use the InputSampler on a SequenceFile<Text,Text> and found that 
> it comes up with duplicate keys in the sample.  The problem was tracked down 
> to the fact that the Text object returned from the reader is essentially a 
> wrapper pointing to a byte array, which changes as the sequence file reader 
> progresses.  There was also a bug in that the reader should be initialized 
> before the use.  The am attaching a patch that fixes both of the issues.  
> --Alex K

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to