[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886242#action_12886242
 ] 

Amareshwari Sriramadasu commented on MAPREDUCE-1248:
----------------------------------------------------

Could not figure out the javac error from console output. Re-ran test-patch on 
my local machine, there are no javac warnings.
test-patch result:
{noformat}
     [exec]
     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
     [exec]                         Please justify why no new tests are needed 
for this patch.
     [exec]                         Also please list what manual steps were 
performed to verify this patch.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
{noformat}

> Redundant memory copying in StreamKeyValUtil
> --------------------------------------------
>
>                 Key: MAPREDUCE-1248
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1248
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/streaming
>            Reporter: Ruibang He
>            Priority: Minor
>         Attachments: MAPREDUCE-1248-v1.0.patch
>
>
> I found that when MROutputThread collecting the output of  Reducer, it calls 
> StreamKeyValUtil.splitKeyVal() and two local byte-arrays are allocated there 
> for each line of output. Later these two byte-arrays are passed to variable 
> key and val. There are twice memory copying here, one is the 
> System.arraycopy() method, the other is inside key.set() / val.set().
> This causes double times of memory copying for the whole output (may lead to 
> higher CPU consumption), and frequent temporay object allocation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to