[ https://issues.apache.org/jira/browse/MAPREDUCE-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887459#action_12887459 ]
Konstantin Boudnik commented on MAPREDUCE-1871: ----------------------------------------------- Thanks for implementing the class container instead of an array. Now with that in place do you still need to bother about the order of the statistics in {{getInfoFromAllClientsForAllTaskType()}}? Seems like it is not necessary any more (you have getters in place) as well as the {{switch(i)}} statement seems like an overkill, is it? - in the {{testTaskTrackerInfoTaskFailure}} the first collection of statistics seems to be unused before the second one is actually done. Is it really should be there? Also, the second collection creates a bunch of temp. int's which are later used for assertions. Why don't you replace the temps with queries? Lesser code is usually better. Same goes for all other tests in {{TestTaskTrackerInfoSuccessfulFailedJobs}} and {{TestTaskTrackerInfoTTProcess}} classes. - replace "mapreduce.job.complete.cancel.delegation.tokens" with proper config key from MR - break the lines like this {{+ setSinceStartTotalTasks(totalInfoValues);break;}} in two: it's hard to read otherwise - make this name more comprehensive like getTTClientInstance {{+ public TTClient getTTClientIns(TaskInfo taskInfo)}}; in the same method, why the loop goes up to 60? {{+ while (counter < 60) { }} - seems to be an unneccesary line break {noformat} + static final Log LOG = LogFactory. + getLog(TTClient.class); {noformat} > Create automated test scenario for "Collect information about number of tasks > succeeded / total per time unit for a tasktracker" > -------------------------------------------------------------------------------------------------------------------------------- > > Key: MAPREDUCE-1871 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1871 > Project: Hadoop Map/Reduce > Issue Type: Test > Components: test > Reporter: Iyappan Srinivasan > Assignee: Iyappan Srinivasan > Attachments: 1871-ydist-security-patch.txt, > 1871-ydist-security-patch.txt, 1871-ydist-security-patch.txt, > 1871-ydist-security-patch.txt, 1871-ydist-security-patch.txt, > 1871-ydist-security-patch.txt, MAPREDUCE-1871.patch, MAPREDUCE-1871.patch, > MAPREDUCE-1871.patch > > > Create automated test scenario for "Collect information about number of tasks > succeeded / total per time unit for a tasktracker" > 1) Verification of all the above mentioned fields with the specified TTs. > Total no. of tasks and successful tasks should be equal to the corresponding > no. of tasks specified in TTs logs > 2) Fail a task on tasktracker. Node UI should update the status of tasks on > that TT accordingly. > 3) Kill a task on tasktracker. Node UI should update the status of tasks on > that TT accordingly > 4) Positive Run simultaneous jobs and check if all the fields are populated > with proper values of tasks. Node UI should have correct valiues for all the > fields mentioned above. > 5) Check the fields across one hour window Fields related to hour should be > updated after every hour > 6) Check the fields across one day window fields related to hour should be > updated after every day > 7) Restart a TT and bring it back. UI should retain the fields values. > 8) Positive Run a bunch of jobs with 0 maps and 0 reduces simultanously. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.