[
https://issues.apache.org/jira/browse/MAPREDUCE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888766#action_12888766
]
Ravi Gummadi commented on MAPREDUCE-1911:
-----------------------------------------
Some comments:
(1) In DumpTypedBytes.java, LoadTypedBytes.java and in HadoopStreaming.java, in
printUsage(), "$HADOOP_HOME/hadoop-streaming.jar" is mentioned, which is not
the correct path of streaming jar. May be it is better to just say
hadoop-streaming.jar instead of giving path.
(2) In DumpTypedBytes.java, in "if (args.length == 0)", before printUsage()
call, printing an error message like "too few arguments to dumptb" would be
useful.
(3) Would it be better to say in printUsage() in HadoopStreaming.java as
"[streamjob]" to signify that streamjob option is optional ?
(4) Description of options/arguments is missing in printUsage() in
LoadTypedBytes and DumpTypedBytes. You can give the same description provided
printUsage() of HadoopStreaming.java. For dumptb, should we say that the input
can be either text file or sequence file ?
Will let you know offline some very minor nits.
> Fix errors in -info option in streaming
> ---------------------------------------
>
> Key: MAPREDUCE-1911
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1911
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/streaming
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.22.0
>
> Attachments: patch-1911-1.txt, patch-1911.txt
>
>
> Here are some of the findings by Karam while verifying -info option in
> streaming:
> # We need to add "Optional" for -mapper, -reducer,-combiner and -file options.
> # For -inputformat and -outputformat options, we should put "Optional" in the
> prefix for the sake on uniformity.
> # We need to remove -cluster decription.
> # -help option is not displayed in usage message.
> # when displaying message for -info or -help options, we should not display
> "Streaming Job Failed!"; also exit code should be 0 in case of -help/-info
> option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
