[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890395#action_12890395
 ] 

Konstantin Boudnik commented on MAPREDUCE-1713:
-----------------------------------------------

bq. Yes, it should required for this test . Because this test checks the 
functionality of restarting the cluster.Some corner cases, it might take more 
than 15 mins based on cluster size. 

I have two issues with this statement:
# 600000 equals to 10 mins and it is less then 15 :)
# we have done a special effort to restart cluster and wait its daemons to come 
back in parallel (nor sequential) and this is exactly your patch is trying to 
do with the test.

So, I suggest to remove this timeout and use the one set by {{build.xml}} 
instead.

> Utilities for system tests specific.
> ------------------------------------
>
>                 Key: MAPREDUCE-1713
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1713
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>          Components: test
>    Affects Versions: 0.21.0
>            Reporter: Vinay Kumar Thota
>            Assignee: Vinay Kumar Thota
>         Attachments: 1713-ydist-security.patch, 1713-ydist-security.patch, 
> 1713-ydist-security.patch, 1713-ydist-security.patch, 
> 1713-ydist-security.patch, MAPREDUCE-1713.patch, MAPREDUCE-1713.patch, 
> MAPREDUCE-1713.patch, systemtestutils_MR1713.patch, 
> utilsforsystemtest_1713.patch
>
>
> 1.  A method for restarting  the daemon with new configuration.
>       public static  void restartCluster(Hashtable<String,Long> props, String 
> confFile) throws Exception;
> 2.  A method for resetting the daemon with default configuration.
>       public void resetCluster() throws Exception;
> 3.  A method for waiting until daemon to stop.
>       public  void waitForClusterToStop() throws Exception;
> 4.  A method for waiting until daemon to start.
>       public  void waitForClusterToStart() throws Exception;
> 5.  A method for checking the job whether it has started or not.
>       public boolean isJobStarted(JobID id) throws IOException;
> 6.  A method for checking the task whether it has started or not.
>       public boolean isTaskStarted(TaskInfo taskInfo) throws IOException;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to