[
https://issues.apache.org/jira/browse/MAPREDUCE-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897535#action_12897535
]
Dick King commented on MAPREDUCE-1598:
--------------------------------------
This comment is a code review.
*This is a minor nit* :
{noformat}
throw new IOException("Mkdirs failed to create " + done.toString());
}
- }
+ } else { // directory exists. Check permissions
+ checkDirectoryPermissions(doneDirFs, done,
+ "mapreduce.jobtracker.jobhistory.completed.location");
+ }
{noformat}
The last {{checkDirectoryPermissions(...)}} call will cruddy up the
indentation. The patch otherwise looks right.
> Wrongly configured 'hadoop.job.history.user.location' can cause jobs to be
> pinned in JobTracker's memory forever
> ----------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1598
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1598
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.20.1
> Reporter: Amar Kamat
> Fix For: 0.20.3
>
> Attachments: mapred-1598
>
>
> Wrongly configured 'hadoop.job.history.user.location' can disable
> job-history. Jobs retires when JobHistory notifies the JobTracker after
> moving the history file to the done folder (i.e
> mapreduce.jobtracker.jobhistory.completed.location). If the JobHistory gets
> disabled, JobTracker would not receive any notification and thus jobs will be
> pinned in JobTracker's memory forever.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
