[
https://issues.apache.org/jira/browse/MAPREDUCE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898992#action_12898992
]
Luke Lu commented on MAPREDUCE-1881:
------------------------------------
One nit for the test code: could have used mock (we have mockito in trunk) to
avoid manually writing a instrumentation class for verification.
I also suggest that you refactor the instrumentation object creation code into
a static factory method so that you can unit test the expected behavior as well.
The code looks fine otherwise, if the above concerns (especially the latter)
are addressed and hudson finds no related issues.
> Improve TaskTrackerInstrumentation
> ----------------------------------
>
> Key: MAPREDUCE-1881
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1881
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Matei Zaharia
> Assignee: Matei Zaharia
> Priority: Minor
> Attachments: mapreduce-1881-v2.patch, mapreduce-1881-v2b.patch,
> mapreduce-1881-v3.patch, mapreduce-1881.patch
>
>
> The TaskTrackerInstrumentation class provides a useful way to capture key
> events at the TaskTracker for use in various reporting tools, but it is
> currently rather limited, because only one TaskTrackerInstrumentation can be
> added to a given TaskTracker and this objects receives minimal information
> about tasks (only their IDs). I propose enhancing the functionality through
> two changes:
> # Support a comma-separated list of TaskTrackerInstrumentation classes rather
> than just a single one in the JobConf, and report events to all of them.
> # Make the reportTaskLaunch and reportTaskEnd methods in
> TaskTrackerInstrumentation receive a reference to a whole Task object rather
> than just its TaskAttemptID. It might also be useful to make the latter
> receive the task's final state, i.e. failed, killed, or successful.
> I'm just posting this here to get a sense of whether this is a good idea. If
> people think it's okay, I will make a patch against trunk that implements
> these changes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
