[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900206#action_12900206
 ] 

Amareshwari Sriramadasu commented on MAPREDUCE-1912:
----------------------------------------------------

Some comments:
* In Folder.java, IllegalArgumentException is caught and main returns the error 
code as IO_ERROR, is this what you intended? Or do you want to return a 
different error code?
* Folder.initialize() is already throwing IllegalArgumentException from parse* 
methods. They are also ignored without printing any message.
* TraceBuilder.run() is catching Throwable and returning exit code as 0. Do you 
want return a different exit code?


> [Rumen] Add a driver for Rumen tool 
> ------------------------------------
>
>                 Key: MAPREDUCE-1912
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1912
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amar Kamat
>            Assignee: Amar Kamat
>             Fix For: 0.22.0
>
>         Attachments: mapreduce-1912-v1.1.patch, mapreduce-1912-v1.7.4.patch
>
>
> Rumen, as a tool, has 2 entry points :
> - Trace builder
> - Folder
> It would be nice to have a single driver program and have 'trace-builder' and 
> 'folder' as its options. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to