[
https://issues.apache.org/jira/browse/MAPREDUCE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905998#action_12905998
]
Hong Tang commented on MAPREDUCE-1918:
--------------------------------------
A few minor nits:
* "Incase" => "in case"
* For TraceBuilder, does it descend recursively into the input foloder, or do
we need to specify the immediate parent directory that contains the files?
* Can we add a bit more details on "demuxer"? How about the following?
bq. Demuxer decides how the input file maps to jobhistory file(s). [insert]Job
history logs and job conf files are typically small files, and can be more
effectively stored if we embed them in some container file format like
SequenceFile or TFile. To support such usage cases, one can specify a
customized Demuxer class that can extract individual job history logs and job
conf files from source files. [/insert]
* There is no need to do canParse() check if you know which parser to use
(hence no need to use ris). The parser will (or should) simply abort if the
source is not of the expected version.
* VersionDetector seems rather internal, getParser() is probably what users
should care about.
> Add documentation to Rumen
> --------------------------
>
> Key: MAPREDUCE-1918
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1918
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: tools/rumen
> Affects Versions: 0.22.0
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Fix For: 0.22.0
>
> Attachments: mapreduce-1918-v1.3.patch, mapreduce-1918-v1.4.patch,
> mapreduce-1918-v1.7.patch, rumen.pdf, rumen.pdf
>
>
> Add forrest documentation to Rumen tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
