[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910488#action_12910488
 ] 

Ravi Gummadi commented on MAPREDUCE-1664:
-----------------------------------------

ant test passed on my local machine.

ant test-patch gave:

     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 63 new or 
modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
     [exec]
     [exec]     +1 system tests framework.  The patch passed system tests 
framework compile.




On a single node cluster, tested different cases for job acls and queue acls 
and supergroup and cluster-owner(user who started the cluster) and job-owner. 
Everything seem to be working as expected.

> Job Acls affect Queue Acls
> --------------------------
>
>                 Key: MAPREDUCE-1664
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1664
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Ravi Gummadi
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1664.20S.3.4.patch, 1664.patch, 
> 1664.qAdminsJobView.20S.v1.6.patch, 1664.v1.1.patch, 1664.v1.2.patch, 
> 1664.v1.patch, M1664y20s-testfix.patch, mr-1664-20-bugfix.patch
>
>
> MAPREDUCE-1307 introduced job ACLs for securing job level operations. So in 
> current trunk, queue ACLs and job ACLs are checked(with AND for both acls) 
> for allowing job level operations. So for doing operations like killJob, 
> killTask and setJobPriority user should be part of both 
> mapred.queue.{queuename}.acl-administer-jobs and in 
> mapreduce.job.acl-modify-job. This needs to change so that users who are part 
> of mapred.queue.{queuename}.acl-administer-jobs will be able to do 
> killJob,killTask,setJobPriority and users part of 
> mapreduce.job.acl-modify-job will be able to do 
> killJob,killTask,setJobPriority.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to