[
https://issues.apache.org/jira/browse/MAPREDUCE-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amareshwari Sriramadasu updated MAPREDUCE-2008:
-----------------------------------------------
Status: Open (was: Patch Available)
Saikat, some comments on the patch:
* The tests should not run by calling Main directly. They should be run as
ToolRunner().run. See TestTeraSort for example.
* System.exit call is commented in all the examples. That should be removed.
* The input for the examples is never generated. Are they running on empty
input?
* There should be a validation for every test to ensure that the example is run
as expected and has produced the expected output.
> write Junit test cases that run the Hadoop examples
> ---------------------------------------------------
>
> Key: MAPREDUCE-2008
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2008
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Components: examples, test
> Affects Versions: 0.20.2
> Environment: N/A
> Reporter: Saikat Kanjilal
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-MR-2008.patch
>
> Original Estimate: 20h
> Remaining Estimate: 20h
>
> I will be adding junit test cases that run the hadoop examples, specifically
> I'll be adding a test suite that tests everything under the
> src/examples/org/apache/hadoop/examples package. Since this is my first
> contribution to the project I'll need some help to figure out how to submit
> this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
