[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919196#action_12919196
 ] 

Simone Leo commented on MAPREDUCE-1125:
---------------------------------------

As suggested on the mapreduce-dev mailing list, I'm attaching results from my 
local test-patch run:

     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 7 new or 
modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
     [exec] 
     [exec]     +1 system tests framework.  The patch passed system tests 
framework compile.


> SerialUtils.cc: deserializeFloat is out of sync with SerialUtils.hh
> -------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1125
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1125
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: pipes
>    Affects Versions: 0.21.0
>            Reporter: Simone Leo
>         Attachments: MAPREDUCE-1125.patch
>
>
> {noformat}
> *** SerialUtils.hh ***
>   float deserializeFloat(InStream& stream);
> *** SerialUtils.cc ***
>   void deserializeFloat(float& t, InStream& stream)
>   {
>     char buf[sizeof(float)];
>     stream.read(buf, sizeof(float));
>     XDR xdrs;
>     xdrmem_create(&xdrs, buf, sizeof(float), XDR_DECODE);
>     xdr_float(&xdrs, &t);
>   }
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to