[
https://issues.apache.org/jira/browse/MAPREDUCE-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922444#action_12922444
]
Scott Chen commented on MAPREDUCE-2132:
---------------------------------------
Thanks for the good work, Ram. This is really nice.
I only have some minor comments.
{code}
+ if (pathStr.contains(RaidNode.HAR_SUFFIX)) {
{code}
Can we use endsWith() to make it more specific?
{code}
+ Path indexFile = new Path(harDirectory + "/_index");
{code}
Can we use some constant like HAR_INDEX_FILENAME here?
It seems the current test fixes only the source block.
Is it possible that you can add a test case that fix the parity file?
> Need a command line option in RaidShell to fix blocks using raid
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-2132
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2132
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/raid
> Reporter: Ramkumar Vadali
> Assignee: Ramkumar Vadali
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-2132.patch
>
>
> RaidShell currently has an option to recover a file and return the path to
> the recovered file. The administrator can then rename the recovered file to
> the damaged file.
> The problem with this is that the file metadata is altered, specifically the
> modification time. Instead we need a way to just repair the damaged blocks
> and send the fixed blocks to a data node.
> Once this is done, we can put automation around it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
