[
https://issues.apache.org/jira/browse/MAPREDUCE-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922880#action_12922880
]
Ravi Gummadi commented on MAPREDUCE-2104:
-----------------------------------------
Some comments on the patch:
(1) Why are the variable names and method names start with the word "expected"
? Since these are the values that are already seen(and not the values
expected), please remove the word "expected" everywhere.
(2) You missed making changes to HadoopLogAnalyzer.incorporateCounters().
(3) You missed making changes to LoggedTaskAttempt.deepCompare().
(4) Empty comments as javadoc are seen for the new methods. Please add some
comments there.
(5) Better to change the new(and may be existing ones also ?) data members of
LoggedTaskAttempt private and use setters and getters everywhere because even
if I change getExpectedVirtualMemorySize() to return
expectedVirtualMemorySizeInBytes-2, testcase is not failing.
> Rumen TraceBuilder Does Not Emit CPU/Memory Usage Details in Traces
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-2104
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2104
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tools/rumen
> Affects Versions: 0.22.0
> Reporter: Ranjit Mathew
> Assignee: Amar Kamat
> Attachments: mapreduce-2104-v1.1.patch
>
>
> Via MAPREDUCE-220, we now have CPU/Memory usage information in MapReduce
> JobHistory files. However, Rumen's TraceBuilder
> does not emit this information in the JSON traces. Without this information,
> GridMix3 cannot emulate CPU/Memory usage correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
