[
https://issues.apache.org/jira/browse/MAPREDUCE-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926195#action_12926195
]
Hong Tang commented on MAPREDUCE-2151:
--------------------------------------
bq. (1) The paths to the new tests seem to be different from existing tests.
src/test/org/apache/hadoop/tools/rumen/Test* instead of
src/test/mapred/org/apache/hadoop/tools/rumen/. Is this intentional ?
No, the tests for trunk are under src/test/mapred. This patch is for yahoo
hadoop 0.20.
bq. (2) TestRumenJobTraces has testJobConfigurationParser() and this patch
added TestJobConfigurationParser.java. Can the old testcase be removed/moved
from TestRumenJobTraces ?
I was not aware of that. I think your suggestion makes sense.
bq. (3) Are we not targeting to get these interested configuration properties
into trace file ?
Yes, TraceBuilder needs to be modified to expose the new feature to end user.
Will add it.
bq. (4) This patch matches only the first part of configuration property(till
first ".")...
I do not follow your first part. For the second part (exclusion list), it will
add significant complexity (now the order of the list may matter). I suggest we
wait until some concrete usage case emerge.
> [rumen] Add a map of jobconf key-value pairs in LoggedJob
> ---------------------------------------------------------
>
> Key: MAPREDUCE-2151
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2151
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Components: tools/rumen
> Reporter: Hong Tang
> Assignee: Hong Tang
> Attachments: mr-2151-yhadoop-20.201.patch
>
>
> It'd be useful to retain application level configuration settings in
> LoggedJob.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
