[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930755#action_12930755
 ] 

Todd Lipcon commented on MAPREDUCE-2073:
----------------------------------------

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or 
modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     -1 findbugs.  The patch appears to introduce 13 new Findbugs 
warnings.
     [exec] 
     [exec]     -1 release audit.  The applied patch generated 2 release audit 
warnings (more than the trunk's current 1 warnings).
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test 
framework compile.

Same as I saw in MAPREDUCE-2034, the test-patch script has some issue. The 
"new" findbugs and release audit issues are in files unrelated to this patch.

> TestTrackerDistributedCacheManager should be up-front about requirements on 
> build environment
> ---------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2073
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2073
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: distributed-cache, test
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>         Attachments: mapreduce-2073-0.20.txt, mapreduce-2073.txt
>
>
> TestTrackerDistributedCacheManager will fail on a system where the build 
> directory is in any path where an ancestor doesn't have a+x permissions. On 
> one of our hudson boxes, for example, hudson's workspace had 700 permissions 
> and caused this test to fail reliably, but not in an obvious manner. It would 
> be helpful if the test failed with a more obvious error message during 
> setUp() when the build environment is misconfigured.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to