[
https://issues.apache.org/jira/browse/MAPREDUCE-2180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930937#action_12930937
]
Todd Lipcon commented on MAPREDUCE-2180:
----------------------------------------
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 13 new Findbugs
warnings.
[exec]
[exec] -1 release audit. The applied patch generated 2 release audit
warnings (more than the trunk's current 1 warnings).
[exec]
[exec] -1 system test framework. The patch failed system test
framework compile.
test-patch on MR produces bad results - findbugs errors are all in
non-fairsched code. Release-audit is also unrelated (this patch does not add
any files). system test framework errors are due to a change that went into
common tonight.
> Add coverage of fair scheduler servlet to system test
> -----------------------------------------------------
>
> Key: MAPREDUCE-2180
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2180
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: contrib/fair-share
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: mapreduce-2180.txt
>
>
> MAPREDUCE-2051 added a system test for the fair scheduler which starts a
> minicluster and runs a couple jobs with preemption on. I recently found a
> deadlock in a previous version of the scheduler that was due to lock
> inversion between the scheduler servlet and some JT internals. I'd like to
> modify the existing system test to also hit the /scheduler servlet, allowing
> jcarder to detect such lock inversions in the future.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
