[
https://issues.apache.org/jira/browse/MAPREDUCE-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933136#action_12933136
]
Eli Collins commented on MAPREDUCE-1878:
----------------------------------------
Thanks Aaron.
{noformat}
[exec]
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no new tests are needed
for this patch.
[exec] Also please list what manual steps were
performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 13 new Findbugs
warnings.
[exec]
[exec] -1 release audit. The applied patch generated 2 release audit
warnings (more than the trunk's current 1 warnings).
[exec]
[exec] +1 system test framework. The patch passed system test
framework compile.
[exec]
{noformat}
The findbugs warnings (MAPREDUCE-2191) are unrelated.
The release audit warning is too:
[rat:report] !?????
/home/eli/src/mapreduce-trunk/build/hadoop-mapred-PATCH-MAPREDUCE-1878.3.patch/webapps/datanode/robots.txt
> Add MRUnit documentation
> ------------------------
>
> Key: MAPREDUCE-1878
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1878
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/mrunit
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1878.2.patch, MAPREDUCE-1878.3.patch,
> MAPREDUCE-1878.patch
>
>
> A short user guide for MRUnit, written in asciidoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
