[
https://issues.apache.org/jira/browse/MAPREDUCE-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934803#action_12934803
]
Vinod K V commented on MAPREDUCE-1978:
--------------------------------------
The patch looks good to me too. I'd be happy if the test can be modified to do
away with all the find/awk kludge - for e.g. {{createHistoryLogsHierarchy()}}
knows the list of files being created and so can return the same; for the flat
list, {{File.listFiles()}} should suffice.
The test results were posted a while ago, please run them once more after the
test changes just to be sure.
> [Rumen] TraceBuilder should provide recursive input folder scanning
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-1978
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1978
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: tools/rumen
> Reporter: Amar Kamat
> Assignee: Ravi Gummadi
> Attachments: 1978.patch, 1978.v1.patch
>
>
> Currently, {{TraceBuilder}} assumes that the input is either jobhistory files
> or a folders containing jobhistory files directly underneath the specified
> folder. There could be a use cases where the input folder could contain
> sub-folders containing jobhistory files. Rumen should support such input
> folders.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
