[
https://issues.apache.org/jira/browse/MAPREDUCE-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972186#action_12972186
]
Joydeep Sen Sarma commented on MAPREDUCE-2116:
----------------------------------------------
@Kang - this routine is still pretty expensive for us (even after putting this
patch in production). can u post a patch with the additional changes u are
suggesting? would be interested in reviewing/trying this out.
i don't understand the shouldClose() very well. i was scared of taking out
logic! another option i was considering is releasing the jobtracker lock in
getTasksToKill and protecting TIP data structures with a TIP level lock. that
will also require substantial amount of work - so definitely interested in a
simpler path.
> optimize getTasksToKill to reduce JobTracker contention
> -------------------------------------------------------
>
> Key: MAPREDUCE-2116
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2116
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: jobtracker
> Reporter: Joydeep Sen Sarma
> Assignee: Joydeep Sen Sarma
> Attachments: 2116.1.patch, 2116.2.patch, 2116.3.patch,
> getTaskToKill.JPG
>
>
> getTasksToKill shows up as one of the top routines holding the JT lock.
> Specifically, the translation from attemptid to tip is very expensive:
> at java.util.TreeMap.getEntry(TreeMap.java:328)
> at java.util.TreeMap.get(TreeMap.java:255)
> at
> org.apache.hadoop.mapred.TaskInProgress.shouldClose(TaskInProgress.java:500)
> at
> org.apache.hadoop.mapred.JobTracker.getTasksToKill(JobTracker.java:3464)
> locked <0x00002aab6ebb6640> (a org.apache.hadoop.mapred.JobTracker)
> at org.apache.hadoop.mapred.JobTracker.heartbeat(JobTracker.java:3181)
> this seems like an avoidable expense since the tip for a given attempt is
> fixed (and one should not need a map lookup to find the association). on a
> different note - not clear to me why TreeMaps are in use here (i didn't find
> any iteration over these maps). any background info on why things are
> arranged the way they are would be useful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
