[
https://issues.apache.org/jira/browse/MAPREDUCE-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975907#action_12975907
]
Todd Lipcon commented on MAPREDUCE-714:
---------------------------------------
bq. Looks like there may be other potential incorrect uses of URLDecode in the
HarFileSystem, minding filling a jira to fix those?
Looking at HarFileSystem, it seems like it's actually safe - it's using
URLDecoder to decode something that was encoded using URLEncoder in
HadoopArchives.java. Using these as a pair is OK:
{code}
groovy:000> URLDecoder.decode(URLEncoder.encode("foo+bar baz 100%"))
===> foo+bar baz 100%
{code}
> JobConf.findContainingJar unescapes unnecessarily on Linux
> ----------------------------------------------------------
>
> Key: MAPREDUCE-714
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-714
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: mapreduce-714.txt
>
>
> In JobConf.findContainingJar, the path name is decoded using
> URLDecoder.decode(...). This was done by Doug in r381794 (commit msg
> "Un-escape containing jar's path, which is URL-encoded. This fixes things
> primarily on Windows, where paths are likely to contain spaces.")
> Unfortunately, jar paths do not appear to be URL encoded on Linux. If you try
> to use "hadoop jar" on a jar with a "+" in it, this function decodes it to a
> space and then the job cannot be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
