[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994991#comment-12994991
 ] 

Roman Shaposhnik commented on MAPREDUCE-2314:
---------------------------------------------

$ ant veryclean test-patch -Dpatch.file=/home/rvs/MAPREDUCE-2314.patch 
-Dscratch.dir=/tmp/mapred/scratch -Dfindbugs.home=/home/rvs/findbugs-1.3.9 
-Dforrest.home=/home/rvs/src/apache-forrest-0.8
.....

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
     [exec]                         Please justify why no new tests are needed 
for this patch.
     [exec]                         Also please list what manual steps were 
performed to verify this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test 
framework compile.


And given that it is a build change " -1 tests included" can be ignored

> configure files that are generated as part of the released tarball need to 
> have executable bit set
> --------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2314
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2314
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>         Attachments: MAPREDUCE-2314.patch
>
>
> Currently the configure files that are packaged in a tarball are -rw-rw-r--

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to