[
https://issues.apache.org/jira/browse/MAPREDUCE-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996655#comment-12996655
]
Tim Yates commented on MAPREDUCE-2325:
--------------------------------------
Oops. Not used to JIRA...
The patch is easy enough, but TIPStatus opens a can of worms. On the one hand,
making getCurrentStatus() private modifies the interface of the Public Stable
subclass o.a.h.mapred.TaskReport. On the other, making TIPStatus public would
expose an o.a.h.mapred class through an o.a.h.mapreduce one.
Some options:
- Move getCurrentStatus() to o.a.h.mapred.TaskReport and remove it from the
o.a.h.mapreduce.TaskReport.
- Make a separate o.a.h.mapreduce.TIPStatus enum and convert back and forth
from its o.a.h.mapred counterpart.
- Make a completely new status enum.
I'm not sure I like any of these. I would hate to get rid of the status
information, but making new enums sounds messy. Other suggestions?
For now, I just make TIPStatus Public Unstable, which is unorthodox, but it led
to fewer build errors than making getCurrentStatus() private.
> Mark o.a.h.mapreduce.TaskReport as public?
> ------------------------------------------
>
> Key: MAPREDUCE-2325
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2325
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.21.0
> Reporter: Tim Yates
> Priority: Minor
> Attachments: MAPREDUCE-2325.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> o.a.h.mapreduce.TaskReport is returned by Job.getTaskReports(TaskType), which
> is marked as Public/Evolving. TaskReport, however, is marked as Private. This
> looks like an oversight: The last time it was mentioned in HADOOP-1623, Tom
> White
> [suggested|https://issues.apache.org/jira/browse/MAPREDUCE-1623?focusedCommentId=12863494&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12863494]
> that it should be Public, but all of the patches continued to use Private.
> If this _isn't_ supposed to be public, where is the best place to get the
> list of running tasks (not just completed ones)?
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
