[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun C Murthy updated MAPREDUCE-2429:
-------------------------------------

    Status: Open  (was: Patch Available)

Sid, the patch looks good. I'll commit when you confirm all unit tests pass.

Some nits:

{quote}
@@ -346,8 +346,9 @@ class ReduceTask extends Task {
   @Override
   @SuppressWarnings("unchecked")
   public void run(JobConf job, final TaskUmbilicalProtocol umbilical)
-    throws IOException, InterruptedException, ClassNotFoundException {
+      throws IOException, InterruptedException, ClassNotFoundException {
     this.umbilical = umbilical;
+    this.jvmContext = jvmContext;
     job.setBoolean("mapred.skip.on", isSkipping());

     if (isMapOrReduce()) {
{quote}

That is a unnecessary change - indentation and assignment of a variable to 
itself. 

There are some more unnecessary indentation changes, bah! :)

> Check jvmid during task status report
> -------------------------------------
>
>                 Key: MAPREDUCE-2429
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2429
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tasktracker
>            Reporter: Arun C Murthy
>            Assignee: Siddharth Seth
>         Attachments: MR2429.patch
>
>
> Currently TT doens't check to ensure jvmid is relevant during communication 
> with the Child via TaskUmbilicalProtocol.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to