[
https://issues.apache.org/jira/browse/MAPREDUCE-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026261#comment-13026261
]
Hadoop QA commented on MAPREDUCE-2416:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12477630/2416.v1.patch
against trunk revision 1097345.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/193//testReport/
Findbugs warnings:
https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/193//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/193//console
This message is automatically generated.
> In Gridmix, in RoundRobinUserResolver, the list of groups for a user obtained
> from users-list-file is incorrect
> ---------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2416
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2416
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.0
>
> Attachments: 2416.patch, 2416.v1.patch
>
>
> RoundRobinUserResolver.parseUserList() has a bug in obtaining list of groups
> for each user --- in the sense that the list is not cleared before obtaining
> groups list for the next user. So if the first line has some groups, then
> from 2nd
> line onwards, the validation of "whether the users(in the next lines) are
> also having group names in those lines" is useless as the list is already
> nonempty.
> For example, users-list-file content as shown below also is valid as per
> parseUserList():
> ------------------
> user1,group1
> user2,
> user3,
> user4,
> ------------------
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
