[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026807#comment-13026807
 ] 

Hadoop QA commented on MAPREDUCE-2457:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12477709/MAPREDUCE-2457-1.patch
  against trunk revision 1097656.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.mapred.TestDebugScript

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: 
https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/196//testReport/
Findbugs warnings: 
https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/196//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/196//console

This message is automatically generated.

> job submission should inject group.name (on the JT side)
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-2457
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2457
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>            Priority: Critical
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-2457-1.patch, MAPREDUCE-2457.patch
>
>
> Until Hadoop 0.20, the JobClient was injecting the property 'group.name' on 
> the JobConf submitted to the JobTracker.
> Since Hadoop 0.21, due to security related changes, this is not done anymore.
> This breaks backwards compatibility for jobs/components that expect the 
> 'group.name' to be automatically set at submission time.
> An example of a component being affected by this change is the FairScheduler 
> where it is common to use the group.name as pool name. Different from other 
> properties, a special characteristic of the group.name is that its value 
> cannot be tampered by a user.
> For security reasons this should not be done (as it was done before) in the 
> JobClient side. Instead, it should be done in the JobTracker when the JobConf 
> is received.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to