[
https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032551#comment-13032551
]
Tom White commented on MAPREDUCE-2338:
--------------------------------------
Thanks for the patch, James. I think the deprecated methods should invoke the
new ones, to avoid code duplication. Also, there's a missing "static" on
KeyFieldBasedComparator.getKeyFieldComparatorOption().
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
> Attachments: MR-2338.1.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should
> not appear as getters and setters in JobConf. For the new API there are
> getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner
> themselves - we should add the equivalent to the old API and deprecate the
> references in JobConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
