[
https://issues.apache.org/jira/browse/MAPREDUCE-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034905#comment-13034905
]
Robert Joseph Evans commented on MAPREDUCE-2495:
------------------------------------------------
Please ignore the previous comment, the patch it is complaining about is not
for trunk, but the 20 security branch.
The following is from the 20 security branch
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or
modified tests.
[exec]
[exec] -1 javadoc. The javadoc tool appears to have generated 1
warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] -1 Eclipse classpath. The patch causes the Eclipse classpath to
differ from the contents of the lib directories.
The javadocs issue is wrong, as both of them generated 6 warnings, and the
Eclipse issue is a known issue.
> The distributed cache cleanup thread has no monitoring to check to see if it
> has died for some reason
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2495
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2495
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: distributed-cache
> Affects Versions: 0.21.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Priority: Minor
> Attachments: MAPREDUCE-2495-20.20X-V1.patch, MAPREDUCE-2495-v1.patch
>
>
> The cleanup thread in the distributed cache handles IOExceptions and the like
> correctly, but just to be a bit more defensive it would be good to monitor
> the thread, and check that it is still alive regularly, so that the
> distributed cache does not fill up the entire disk on the node.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
