[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035035#comment-13035035
 ] 

Todd Lipcon commented on MAPREDUCE-2372:
----------------------------------------

was just looking this over before commit and decided that the default of "100" 
for the logsize property isn't for any particularly good reason. Instead it 
should probably be "0", which disables the queueing/truncation ability and is 
the default used by TaskLog.getTaskLogLength

> TaskLogAppender mechanism shouldn't be set in log4j.properties
> --------------------------------------------------------------
>
>                 Key: MAPREDUCE-2372
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2372
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: task
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: mapreduce-2372.txt, mapreduce-2372.txt, 
> mapreduce-2372.txt
>
>
> The TaskLogAppender log4j appender relies on using log4j.properties to pass 
> in some Java system properties into properties of the logger. This is 
> problematic since we've often found that users have customized 
> log4j.properties and don't upgrade it when they upgrade the version of Hadoop.
> Since this is really an internal mechanism of how the task runner passes task 
> info to the TLA, we shouldn't rely on these settings in log4j.properties at 
> all. Rather, we should just get the system properties directly from 
> System.getProperty.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to