[
https://issues.apache.org/jira/browse/MAPREDUCE-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035730#comment-13035730
]
Todd Lipcon commented on MAPREDUCE-2322:
----------------------------------------
Hi Albert. A few comments:
- maybe it would make sense to move these methods and the PathFilter
implementation into JobHistory.java? Then it would be really easy to write unit
tests for them.
- looks like there is a hard tab character in the patch. Our code convention is
to use spaces rather than tabs. Can you make sure your editor is setup for that?
> Throw better error message when malformed filenames in history dir
> ------------------------------------------------------------------
>
> Key: MAPREDUCE-2322
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2322
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Albert Sunwoo
> Priority: Minor
> Labels: newbie
> Attachments: MAPREDUCE-2322.patch, MAPREDUCE-2322.patch
>
>
> I've occasionally seen an IndexOutOfBoundsException visiting jobhistory.jsp
> because some file makes it into the history log directory. We should filter
> these out and throw a more useful exception if a malformed one somehow makes
> it to the comparator
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
